Fix gRPC API link #216
Merged
Fix gRPC API link #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link to gRPC API was broken, leading to 404 error.
Co-authored-by: Adhitya Mamallan <[email protected]>
ibarrajo
suggested changes
Feb 12, 2025
Contributor
ibarrajo
left a comment
ibarrajo
left a comment
There was a problem hiding this comment.
Double checked this PR, the link should be:
https://github.com/cadence-workflow/cadence-idl/tree/master/proto/uber/cadence/api/v1
What happened is that during the github org migration from uber/cadence to cadence-workflow/cadence the link was rewritten.
We are yet to update the proto package name here:
https://github.com/cadence-workflow/cadence-idl/blob/master/proto/uber/cadence/admin/v1/service.proto#L23C1-L23C30
Contributor
Author
|
Thanks @ibarrajo! Based on @adhityamamallan's comment, the PR is now updated with the new link (https://github.com/cadence-workflow/cadence-idl/tree/master/proto/uber/cadence/api/v1) |
adhityamamallan
approved these changes
Feb 12, 2025
davidporter-id-au
approved these changes
Feb 13, 2025
ibarrajo
pushed a commit
to ibarrajo/cadence-docs
that referenced
this pull request
Feb 24, 2025
* Fix gRPC API link The link to gRPC API was broken, leading to 404 error. * Update the reference URL Co-authored-by: Adhitya Mamallan <[email protected]> --------- Co-authored-by: Adhitya Mamallan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to gRPC API was broken, leading to 404 error.