-
Notifications
You must be signed in to change notification settings - Fork 85
Improve Java client documentation #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| | **Auto heartbeat** | Supported | No | - | | ||
| | **Jitter start** | Supported | No | - | | ||
| | **Migrate from tchannel to gRPC** | Supported | No | P2 | | ||
| | **Missing methods** | Supported | No | P2 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarity on what this is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed
| | **Same request ID for retries** | Supported | No | P0 | | ||
| | **Cadence canary alerting** | Supported | No | P0 | | ||
| | **Context propagator** | Supported | No | P1 | | ||
| | **Customer provided context propagator** | Supported | No | P1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need clarity on what this is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed
|
|
||
| ### Feature Comparison | ||
|
|
||
| | Feature | Go Client | Java Client | Priority | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to create a github issue for missing functionality in the cadence-java-client repository and link it here. That would provide additional context for readers and also provide a starting point for new contributors. Since there's an existing implementation to look at it's much more straightforward to go about implementing.
I think this list is also heavily biased towards things that we don't have since we were tracking this for the purpose of improving the Java client. Generally it has all the core features that you'd expect in a Cadence client. Workers, Workflows, Activities, Local Activities, Locally Dispatched Activities, Signals, SignalWithStart, Querying, Cancellation, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! added a link to the issues where applicable!
|
|
||
| | Feature | Go Client | Java Client | Issue | | ||
| |--------------------------------------------------------|-----------|-------------|-------| | ||
| | **Up to Date Samples** | Supported | No | [Link](https://github.com/cadence-workflow/cadence-java-samples/issues) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To nit-pick a bit, while this is probably a fair comment, it's hard to quantify or know when it's no longer true. So I'd suggest removing it just because otherwise it just seems like a perpetual subjective problem probably
Adding feature matrix between cadence-go-client and cadence-java-client
Screenshot (updated March 12th)

Improved links to Java resources
Enabled
showLastUpdateAuthorandshowLastUpdateTimefor documentation pages