docs: update Golang Hello World tutorial #271
Merged
+57
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // add to the function startWorker before calling worker.Start() | ||
|
|
||
| // if err != nil { |
Contributor
Author
There was a problem hiding this comment.
@davidporter-id-au I added those lines intentionally. Btw, I have removed.
Contributor
Author
There was a problem hiding this comment.
@davidporter-id-au Are there any concerns from you about this PR?
ansidev
force-pushed
the
fix-golang-hello-world-tutorial
branch
from
b192810 to
932a44c
Compare
shijiesheng
approved these changes
Sep 3, 2025
Contributor
Author
|
@shijiesheng Would you mind merging this PR? I do not have the permissions to do that. |
davidporter-id-au
approved these changes
Sep 3, 2025
Member
davidporter-id-au
left a comment
davidporter-id-au
left a comment
There was a problem hiding this comment.
no concerns, sorry if I misinterpreted the if/err != nil thing earlier, it looked at a glance like accidentally commented code
Contributor
Author
|
@davidporter-id-au Could you please merge the PR? I do not have the permissions to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Update Golang Hello World tutorial.
How did you test it?
local tests