add unit test

Author: shijiesheng

internal/internal_task_pollers_test.go

@@ -26,6 +26,8 @@ import (
 	"testing"
 	"time"
 
+	"go.uber.org/zap/zaptest/observer"
+
 	"go.uber.org/cadence/internal/common/testlogger"
 
 	"github.com/golang/mock/gomock"
@@ -111,21 +113,22 @@ func TestWorkflowTaskPoller(t *testing.T) {
 }
 
 func TestActivityTaskPoller(t *testing.T) {
+	task := &s.PollForActivityTaskResponse{
+		TaskToken: []byte("some value"),
+		AutoConfigHint: &s.AutoConfigHint{
+			common.PtrOf(true),
+			common.PtrOf(int64(1000)),
+		},
+	}
+	emptyTask := &s.PollForActivityTaskResponse{
+		TaskToken: nil,
+		AutoConfigHint: &s.AutoConfigHint{
+			common.PtrOf(true),
+			common.PtrOf(int64(1000)),
+		},
+	}
 	t.Run("PollTask", func(t *testing.T) {
-		task := &s.PollForActivityTaskResponse{
-			TaskToken: []byte("some value"),
-			AutoConfigHint: &s.AutoConfigHint{
-				common.PtrOf(true),
-				common.PtrOf(int64(1000)),
-			},
-		}
-		emptyTask := &s.PollForActivityTaskResponse{
-			TaskToken: nil,
-			AutoConfigHint: &s.AutoConfigHint{
-				common.PtrOf(true),
-				common.PtrOf(int64(1000)),
-			},
-		}
+
 		for _, tt := range []struct {
 			name     string
 			response *s.PollForActivityTaskResponse
@@ -147,7 +150,7 @@ func TestActivityTaskPoller(t *testing.T) {
 			},
 		} {
 			t.Run(tt.name, func(t *testing.T) {
-				poller, client := buildActivityTaskPoller(t)
+				poller, client, _ := buildActivityTaskPoller(t)
 				client.EXPECT().PollForActivityTask(gomock.Any(), gomock.Any(), gomock.Any()).Return(tt.response, nil)
 				result, err := poller.PollTask()
 				assert.NoError(t, err)
@@ -157,6 +160,12 @@ func TestActivityTaskPoller(t *testing.T) {
 			})
 		}
 	})
+	t.Run("ProcessTask Empty Task", func(t *testing.T) {
+		poller, _, obs := buildActivityTaskPoller(t)
+		err := poller.ProcessTask(&activityTask{task: emptyTask})
+		assert.NoError(t, err)
+		assert.Len(t, obs.FilterMessage("Activity task unavailable").All(), 1)
+	})
 }
 
 func TestLocalActivityPanic(t *testing.T) {
@@ -312,9 +321,10 @@ func buildWorkflowTaskPoller(t *testing.T) (*workflowTaskPoller, *workflowservic
 	}, mockService, taskHandler, lda
 }
 
-func buildActivityTaskPoller(t *testing.T) (*activityTaskPoller, *workflowservicetest.MockClient) {
+func buildActivityTaskPoller(t *testing.T) (*activityTaskPoller, *workflowservicetest.MockClient, *observer.ObservedLogs) {
 	ctrl := gomock.NewController(t)
 	mockService := workflowservicetest.NewMockClient(ctrl)
+	logger, obs := testlogger.NewObserved(t)
 	return &activityTaskPoller{
 		basePoller: basePoller{
 			shutdownC: make(<-chan struct{}),
@@ -324,7 +334,7 @@ func buildActivityTaskPoller(t *testing.T) (*activityTaskPoller, *workflowservic
 		identity:     _testIdentity,
 		service:      mockService,
 		metricsScope: &metrics.TaggedScope{Scope: tally.NewTestScope("test", nil)},
-		logger:       testlogger.NewZap(t),
+		logger:       logger,
 		featureFlags: FeatureFlags{},
-	}, mockService
+	}, mockService, obs
 }