Skip to content

improve example test by sorting output #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2024
Merged

improve example test by sorting output #1366

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
966478b
improve example test by sorting output
ketsiambaku Sep 10, 2024
b43a28f
replace slices pkg with sort
ketsiambaku Sep 10, 2024
9da3fea
address comments
ketsiambaku Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/common/debug/example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ package debug
import (
"encoding/json"
"fmt"
"sort"
"strings"
"sync"

"go.uber.org/atomic"
Expand Down Expand Up @@ -75,6 +77,9 @@ func (ati *activityTrackerImpl) Stats() Activities {
}{Info: a, Count: count})
}
}
sort.Slice(activities, func(i, j int) bool {
return strings.Compare(strings.ToLower(activities[i].Info.ActivityType), strings.ToLower(activities[j].Info.ActivityType)) < 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting makes perfect sense, but there's no reason to ToLower here afaict. It'll just make things more ambiguous than they are IRL, where strings need to be identical in both workers and example-test output checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

})
return activities
}

Expand Down
Loading