Skip to content

Add unit tests for event handlers #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Add unit tests for event handlers #1387

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a3ef70
Add unit tests for event handlers
3vilhamster Nov 6, 2024
163ff57
remove noop return
3vilhamster Nov 6, 2024
955283f
cleanup and comments
3vilhamster Nov 6, 2024
50384ae
revert error handling for now
3vilhamster Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func Test_SignalExternalWorkflowExecutionFailedError(t *testing.T) {
InitiatedEventId: common.Int64Ptr(initiatedEventID),
Cause: shared.SignalExternalWorkflowExecutionFailedCauseUnknownExternalWorkflowExecution.Ptr(),
})
require.NoError(t, weh.handleSignalExternalWorkflowExecutionFailed(event))
weh.handleSignalExternalWorkflowExecutionFailed(event)
_, ok := actualErr.(*UnknownExternalWorkflowExecutionError)
require.True(t, ok)
}
Expand Down
Loading
Loading