Skip to content

Conversation

@3vilhamster
Copy link
Contributor

What changed?
Add unit tests for GetVersion and added a log for error in UpsertSearchAttributes.

The error handling is a noop and happens only if we cannot serialize data. This is not expected to happen with the existing GetVersion API.

Why?
Improving test coverage.

How did you test it?

Potential risks

@codecov
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (17b9b1a) to head (3271d90).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/internal_event_handlers.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
internal/internal_event_handlers.go 62.03% <25.00%> (+2.91%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b9b1a...3271d90. Read the comment docs.

@3vilhamster 3vilhamster merged commit aa18e1d into cadence-workflow:master Nov 6, 2024
12 of 13 checks passed
@3vilhamster 3vilhamster deleted the getversion-tests branch November 6, 2024 12:53
mrombout pushed a commit to softsense/cadence-client that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants