[cadence/debug] Update polletracker to support poller type breakdown#1406
Open
ketsiambaku wants to merge 1 commit intocadence-workflow:masterfrom
Open
[cadence/debug] Update polletracker to support poller type breakdown#1406ketsiambaku wants to merge 1 commit intocadence-workflow:masterfrom
ketsiambaku wants to merge 1 commit intocadence-workflow:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
We use the PollerTracker interface to count the number of running pollers and we display it internal in a debug page.
This change is updating the interface and its usage so that the poller count is broken down by worker type (e.g: activity, workflow, shadow, localactivity, etc.)
Why?
The break down gives a better insight on the running instance
How did you test it?
unit tests
Potential risks