update IDL #1408
update IDL #1408
Conversation
shijiesheng
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht and
taylanisikdemir
as code owners
| } | ||
| } | ||
|
|
||
| func DiagnoseWorkflowExecutionRequest(t *shared.DiagnoseWorkflowExecutionRequest) *apiv1.DiagnoseWorkflowExecutionRequest { |
There was a problem hiding this comment.
I am not super happy with this API's response. It just returns wfid/runid corresponding to the diagnostic workflow which means user has to make subsequent API calls to get diagnosis results. I think this was designed to be used by CLI but we have to expose it here in SDKs too unfortunately.
| return result, err | ||
| } | ||
|
|
||
| func (w *workflowServiceAuthWrapper) DiagnoseWorkflowExecution(ctx context.Context, request *shared.DiagnoseWorkflowExecutionRequest, opts ...yarpc.CallOption) (*shared.DiagnoseWorkflowExecutionResponse, error) { |
There was a problem hiding this comment.
please update unit tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What changed? new endpoint DiagnoseWorkflowExecution new field AutoConfigHint in Poll responses Why? new field is needed for worker auto config project How did you test it? unit test
2 participants
What changed?
DiagnoseWorkflowExecutionAutoConfigHintin Poll responsesWhy?
new field is needed for worker auto config project
How did you test it?
unit test
Potential risks