poller auto scaler rework #1409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht and
taylanisikdemir
as code owners
Shaddoll
reviewed
Dec 5, 2024
|
|
||
| // Permit is an adaptive permit issuer to control concurrency | ||
| type Permit interface { | ||
| Acquire(context.Context) error |
There was a problem hiding this comment.
do you mind adding comments for each method?
There was a problem hiding this comment.
sorry this branch was accidentally pushed. I'm still testing this branch #1411
|
closed and see #1411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks