Skip to content

Conversation

demirkayaender
Copy link
Member

@demirkayaender demirkayaender commented May 5, 2025

Detailed Description
Changing our license to Apache 2.0 to be consistent across our org.

Impact Analysis

  • Backward Compatibility: No impact expected
  • Forward Compatibility: No impact expected

Testing Plan

  • Unit Tests: Shouldn't be needed.
  • Persistence Tests: Shouldn't be needed.
  • Integration Tests: Shouldn't be needed.
  • Compatibility Tests: Shouldn't be needed.

Rollout Plan
Shouldn't have any impact in any of the following questions

  • What is the rollout plan?
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter?
  • Is there a kill switch to mitigate the impact immediately?

Copy link
Member

@Groxx Groxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, looks good and I'm pretty sure that'll pass CI 👍

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (dd7df58) to head (ad66506).
Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/activity.go 89.71% <ø> (ø)
internal/encoded.go 79.31% <ø> (ø)
internal/internal_public.go 100.00% <ø> (ø)
internal/internal_task_pollers.go 83.28% <ø> (ø)
internal/internal_workflow_client.go 89.37% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7df58...ad66506. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@demirkayaender demirkayaender merged commit a061890 into cadence-workflow:master May 5, 2025
11 checks passed
@demirkayaender demirkayaender deleted the go-client-license branch May 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants