Revert "Populate tasks in internal workflowTask and activityTask entities" #1424
Conversation
shijiesheng
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht and
taylanisikdemir
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
internal/internal_task_pollers.go
Outdated
|
|
||
| activityTask := task.(*activityTask) | ||
| if activityTask.task == nil { | ||
| if activityTask.task == nil || len(activityTask.task.TaskToken) == 0 { |
There was a problem hiding this comment.
do we need a similar change on workflow tasks? since that path was changed too.
There was a problem hiding this comment.
WorkflowTask doesn't need change since it's already handling emptiness here
There was a problem hiding this comment.
👍 thanks, I'm convinced :) same kinds of paths as before then, should be safe.
…ties for empty polls (cadence-workflow#1416)" This reverts commit d9dcddc.
shijiesheng
force-pushed
the
fix-panic-empty-poll
branch
from
9279bdf to
a984be6
Compare
shijiesheng
changed the title
3 participants
What changed?
A pure revert of d9dcddc#diff-caac3c5868c1fd134487cacc53e459b7375722e23c6aba3e9407521feba00007
Why?
Nilness check is no longer enough after the commit
One alternative is to add additional emptiness check. This makes the client code error prone. Thus, a pure revert is desired.
How did you test it?
Unit Test
Potential risks