Add active cluster selection policy to workflow start options #1438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
[In-depth description of the changes made to the interfaces, specifying new fields, removed fields, or modified data structures]
Following changes are made to support specifying custom policies for active-active domains:
ActiveClusterSelectionPolicy
is added to workflow start optionsMisc change:
CronOverlapPolicy
to compatibility layer which was missed in Introduce CronOverlapPolicy in StartWorkflowOptions from cadence-idl #1425Impact Analysis
New field. ok to be nil.
Not rollback compatible once users start taking dependency on this.
Testing Plan
Already handled in server repo.
Already handled in server repo.
Will be done in dev environment
Rollout Plan
Create a new prerelease and try it in canary services.
Server changes must be deployed first before clients start using this.
Yes before users start taking dependency on new field.
Rolling back client is safe and should mitigate unforeseen issues. Server side changes are already in.