Skip to content

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Jul 8, 2025

Detailed Description
[In-depth description of the changes made to the interfaces, specifying new fields, removed fields, or modified data structures]

Following changes are made to support specifying custom policies for active-active domains:

  • ActiveClusterSelectionPolicy is added to workflow start options
  • Corresponding compatibility layers, mappers and tests updated

Misc change:

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility]
    New field. ok to be nil.
  • Forward Compatibility: [Analysis of forward compatibility]
    Not rollback compatible once users start taking dependency on this.

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?] Yes
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
    Already handled in server repo.
  • Integration Tests: [Do we have integration test covering the change?]
    Already handled in server repo.
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]
    Will be done in dev environment

Rollout Plan

  • What is the rollout plan?
    Create a new prerelease and try it in canary services.
  • Does the order of deployment matter?
    Server changes must be deployed first before clients start using this.
  • Is it safe to rollback? Does the order of rollback matter?
    Yes before users start taking dependency on new field.
  • Is there a kill switch to mitigate the impact immediately?
    Rolling back client is safe and should mitigate unforeseen issues. Server side changes are already in.

@taylanisikdemir taylanisikdemir force-pushed the taylan/act_cl_sel_plcy branch from f3b8b56 to dc0978b Compare July 8, 2025 23:03
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.09%. Comparing base (e9e55a9) to head (dc0978b).

Files with missing lines Patch % Lines
internal/internal_workflow_client.go 70.00% 2 Missing and 1 partial ⚠️
internal/convert.go 94.87% 2 Missing ⚠️
Files with missing lines Coverage Δ
internal/client.go 75.86% <ø> (ø)
internal/workflow.go 76.44% <ø> (-0.12%) ⬇️
internal/convert.go 94.87% <94.87%> (ø)
internal/internal_workflow_client.go 89.17% <70.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e55a9...dc0978b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taylanisikdemir taylanisikdemir merged commit 40074ec into cadence-workflow:master Jul 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants