Add HasActivityInfo to avoid panic recover on GetActivityInfo #1447
+37
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description
Added a new method
HasActivityInfo
toactivity.go
.We use
GetActivityInfo
a lot to create some metrics in one core component. This component is heavily used in the system and called not only from cadence activities but also in other places. The current implementation ofGetActivityInfo
panicking if called not from the activity, it forces us to use panic-recover pattern which works but pollutes logs a lot:We would like to avoid it with this:
Impact Analysis
Testing Plan
Rollout Plan
Merge it and release a new client version
No
Safe to rollback, the order doesn't matter
No, not needed