Skip to content

Conversation

mandyschen
Copy link
Contributor

What changed?
Added always uploading artifacts

Why?
So even in failure, can look at the artifacts

How did you test it?
Will test using Github Actions

Potential risks

@mandyschen
Copy link
Contributor Author

Files are uploaded as long as they exist (even with error):
image

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (9ee0f06) to head (f6c80c6).
⚠️ Report is 1 commits behind head on master.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee0f06...f6c80c6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mandyschen mandyschen marked this pull request as ready for review July 31, 2025 21:20
Copy link
Member

@shijiesheng shijiesheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mandyschen mandyschen merged commit d867eeb into master Jul 31, 2025
21 checks passed
@mandyschen mandyschen deleted the mandychen/always-upload-artifacts branch July 31, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants