Skip to content

Add support for Ephemeral TaskLists #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natemort
Copy link
Member

@natemort natemort commented Aug 7, 2025

Update Sessions to use Ephemeral TaskLists behind a feature flag. This ensures that the per-host TaskList is automatically removed once it is no longer used.

This should only be enabled once the server fully supports Ephemeral TaskLists as it will otherwise return errors for the unknown TaskListKind.

What changed?

  • Added support for dispatching session activities to ephemeral TaskLists and polling Ephemeral TaskLists

Why?

  • To support automatically removing session and integration test TaskLists when they're no longer used.

How did you test it?

  • Unit/integration test. Will run through canary tests before enabling.

Potential risks

  • Errors in task polling would significantly impact users, so this is a high risk change.

Update Sessions to use Ephemeral TaskLists behind a feature flag. This ensures that the per-host TaskList is automatically removed once it is no longer used.

This should only be enabled once the server fully supports Ephemeral TaskLists as it will otherwise return errors for the unknown TaskListKind.
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.72%. Comparing base (97eba63) to head (33955d2).

Files with missing lines Patch % Lines
internal/internal_event_handlers.go 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
internal/activity_task_handler.go 96.77% <100.00%> (ø)
internal/client.go 76.06% <100.00%> (+0.20%) ⬆️
internal/internal_activity.go 62.15% <ø> (ø)
internal/internal_task_handlers.go 81.90% <100.00%> (+0.03%) ⬆️
internal/internal_task_pollers.go 82.85% <100.00%> (-0.62%) ⬇️
internal/internal_utils.go 76.58% <ø> (ø)
internal/internal_worker.go 82.59% <100.00%> (+5.98%) ⬆️
internal/internal_worker_base.go 73.56% <ø> (+1.32%) ⬆️
internal/workflow.go 76.58% <100.00%> (+0.14%) ⬆️
internal/workflow_replayer.go 77.82% <100.00%> (+0.30%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97eba63...33955d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant