remove unnecessary debug level logging for autoscaler event #1453
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht and
taylanisikdemir
as code owners
taylanisikdemir
approved these changes
Aug 13, 2025
shijiesheng
force-pushed
the
autoscaler-remove-log
branch
from
f88ff08 to
312914a
Compare
Groxx
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Emit metrics logging happens every "cooldown time" (10s by default) and thus created a ton of debug logging. These logging are not needed.
Why?
Some user complains about too much debug level logging
How did you test it?
unit test
Potential risks