Skip to content

Conversation

shijiesheng
Copy link
Member

What changed?

  • activityWorker poll should populate autoConfigHint
  • workflowWorker poll additional field population. This is optional but is good to have it

Why?

Activity worker doesn't process auto config hint on empty polls

How did you test it?

Unit Test

Local Test with Cadence-Samples. Now it's scaling down correctly on empty poll scenarios
Screenshot 2025-08-27 at 1 56 18 PM

Also there is no panic/error logs in local testing

Potential risks

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.51%. Comparing base (6b9605b) to head (c894c5c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/internal_task_pollers.go 86.07% <100.00%> (+2.57%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9605b...c894c5c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shijiesheng shijiesheng merged commit 061b43b into cadence-workflow:master Aug 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants