Skip to content

Conversation

@Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Oct 27, 2025

What changed?
Detailed Description

  • Pull latest changes from active-active

Why?
We redesigned and reimplemented active-active domains feature and made some breaking changes to IDL.

How did you test it?
unit tests

Potential risks
This might be a breaking change, but we only broke changes available in release candidates and they're not available in any formal release.

Impact Analysis

  • Backward Compatibility: N/A Since introducing a new endpoint
  • Forward Compatibility: N/A

Testing Plan

  • Unit Tests: We have unit tests for these changes
  • Persistence Tests: N/A
  • Integration Tests: tested with integration tests
  • Compatibility Tests: N/A

Rollout Plan

  • What is the rollout plan? Rollout wave by wave starting from staging
  • Does the order of deployment matter? No
  • Is it safe to rollback? Does the order of rollback matter? Yes
  • Is there a kill switch to mitigate the impact immediately? No

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.74%. Comparing base (7ce86d7) to head (6311f67).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/client.go 74.50% <ø> (-1.56%) ⬇️
internal/common/auth/service_wrapper.go 94.08% <100.00%> (+0.13%) ⬆️
internal/common/isolationgroup/service_wrapper.go 92.14% <100.00%> (+0.12%) ⬆️
internal/common/metrics/service_wrapper.go 98.84% <100.00%> (+0.40%) ⬆️
internal/convert.go 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce86d7...6311f67. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidporter-id-au
Copy link
Member

I am not super familiar with the test-cases of the Client version. I don't see a lot of test code changes here. Are you able to ensure that the mappers for proto/thrift have adequate coverage such that if they don't round-trip, for example, this will be caught?

@Shaddoll Shaddoll merged commit cf0b546 into master Oct 28, 2025
19 checks passed
@Shaddoll Shaddoll deleted the aa branch October 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants