fix: missing fields for FailoverDomain API call #1478
Merged
+204
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Porter <[email protected]>
davidporter-id-au
force-pushed
the
feature/fixing-missing-fields
branch
from
b9e3a96 to
e9403f6
Compare
davidporter-id-au
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
davidporter-id-au
requested review from
3vilhamster,
demirkayaender,
dkrotx,
jakobht,
shijiesheng and
taylanisikdemir
as code owners
| } | ||
| } | ||
| case reflect.Map: | ||
| for _, key := range field.MapKeys() { |
Member
Author
There was a problem hiding this comment.
needed to add this because it was missing few fields
Shaddoll
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The FailoverDomain endpoint is missing a few fields for cluster attributes. This maps them and adds a few tests to cover this. More problematic, is the response struct which, to be honest, I didn't realise was returning the entire domain data. So this also updates / maps that.
Why?
How did you test it?
Potential risks