Skip to content

fix updateDomainRequest mapper bug #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
+5 −2
Merged

fix updateDomainRequest mapper bug #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/uber/cadence/internal/compatibility/proto/RequestMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ public static UpdateDomainRequest updateDomainRequest(com.uber.cadence.UpdateDom
fields.add(DomainUpdateVisibilityArchivalURIField);
}
}
DomainReplicationConfiguration replicationConfiguration = new DomainReplicationConfiguration();
DomainReplicationConfiguration replicationConfiguration = t.getReplicationConfiguration();
if (replicationConfiguration != null) {
if (replicationConfiguration.getActiveClusterName() != null) {
request.setActiveClusterName(replicationConfiguration.getActiveClusterName());
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/com/uber/cadence/internal/compatibility/ProtoObjects.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,8 @@ public final class ProtoObjects {
.setHistoryArchivalUri("historyArchivalUri")
.setVisibilityArchivalStatus(ArchivalStatus.ARCHIVAL_STATUS_DISABLED)
.setVisibilityArchivalUri("visibilityArchivalUri")
.addAllClusters(ImmutableList.of(CLUSTER_REPLICATION_CONFIGURATION))
.setActiveClusterName("activeCluster")
.setDeleteBadBinary("deleteBadBinary")
.setFailoverTimeout(seconds(1))
.setUpdateMask(
Expand All @@ -1185,6 +1187,8 @@ public final class ProtoObjects {
.addPaths("history_archival_uri")
.addPaths("visibility_archival_status")
.addPaths("visibility_archival_uri")
.addPaths("active_cluster_name")
.addPaths("clusters")
.addPaths("delete_bad_binary")
.addPaths("failover_timeout")
.build())
Expand Down
1 change: 0 additions & 1 deletion src/test/java/com/uber/cadence/internal/compatibility/proto/RequestMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ public static Iterable<Object[]> cases() {
"emitMetric"), // Thrift has this field but proto doens't have it
testCase(
ThriftObjects.UPDATE_DOMAIN_REQUEST,
// Data and replicationConfiguration are copied incorrectly due to a bug :(
ProtoObjects.UPDATE_DOMAIN_REQUEST,
RequestMapper::updateDomainRequest),
testCase(
Expand Down
Loading