Add CronoverlapPolicy support to java client #1018
Open
+594
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
requested review from
Groxx,
abhishekj720,
natemort,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
shijiesheng
reviewed
Aug 12, 2025
| @@ -86,6 +87,8 @@ public static final class Builder { | |||
|
|
|||
| private String cronSchedule; | |||
|
|
|||
| private int cronOverlapPolicy; | |||
There was a problem hiding this comment.
use thrift entity similar to WorkflowIdReusePolicy
shijiesheng
reviewed
Aug 12, 2025
| @@ -56,6 +56,8 @@ public final class StartWorkflowExecutionParameters { | |||
|
|
|||
| private Duration delayStart; | |||
|
|
|||
| private int cronOverlapPolicy; | |||
| @@ -51,6 +51,8 @@ public static final class Builder { | |||
|
|
|||
| private String cronSchedule; | |||
|
|
|||
| private int cronOverlapPolicy; | |||
| @@ -64,6 +64,7 @@ public static WorkflowOptions merge( | |||
| .setRetryOptions(RetryOptions.merge(methodRetry, o.getRetryOptions())) | |||
| .setCronSchedule(OptionsUtils.merge(cronAnnotation, o.getCronSchedule(), String.class)) | |||
| .setMemo(o.getMemo()) | |||
| .setCronOverlapPolicy(o.cronOverlapPolicy) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added
cronOverlapPolicyfield to support cron workflow overlap policies in:WorkflowOptions- field with getter, setter, equals, hashCode, toString, mergeStartWorkflowExecutionParameters- field with CRUD operations and propagationStartChildWorkflowExecutionParameters- field with CRUD operationsChildWorkflowOptions- field with getter, setter, mergeSyncDecisionContext- updated to pass field to child workflow parametersHowever, this feature is not yet working since idl related change is not merged (will be added in a later pr)
Why?
need to add corresponding logic for
cronOverlapPolicythat is already implemented in server and go clientHow did you test it?
unit tests
Potential risks
Release notes
Documentation Changes