Skip to content

Add attempt number to structured activity logger #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
+3 −0
Merged

Add attempt number to structured activity logger #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/uber/cadence/internal/logging/LoggerTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,5 @@ public class LoggerTag {
public static final String TASK_LIST = "TaskList";
public static final String WORKFLOW_ID = "WorkflowID";
public static final String WORKFLOW_TYPE = "WorkflowType";
public static final String ATTEMPT = "Attempt";
}
2 changes: 2 additions & 0 deletions src/main/java/com/uber/cadence/internal/worker/ActivityWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ public void handle(PollForActivityTaskResponse task) throws Exception {
MDC.put(LoggerTag.ACTIVITY_TYPE, task.getActivityType().getName());
MDC.put(LoggerTag.WORKFLOW_ID, task.getWorkflowExecution().getWorkflowId());
MDC.put(LoggerTag.RUN_ID, task.getWorkflowExecution().getRunId());
MDC.put(LoggerTag.ATTEMPT, String.valueOf(task.getAttempt()));

propagateContext(task);
Span span = spanFactory.spanForExecuteActivity(task);
Expand Down Expand Up @@ -175,6 +176,7 @@ public void handle(PollForActivityTaskResponse task) throws Exception {
MDC.remove(LoggerTag.ACTIVITY_TYPE);
MDC.remove(LoggerTag.WORKFLOW_ID);
MDC.remove(LoggerTag.RUN_ID);
MDC.remove(LoggerTag.ATTEMPT);
unsetCurrentContext();
}
}
Expand Down