Thrift Deprecation Part 1: new entities #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort and
taylanisikdemir
as code owners
shijiesheng
force-pushed
the
v4.x.x-entities
branch
from
36e81b7 to
5cd8b15
Compare
Signed-off-by: Shijie Sheng <[email protected]>
shijiesheng
force-pushed
the
v4.x.x-entities
branch
from
5cd8b15 to
e8a2ca0
Compare
natemort
approved these changes
Sep 26, 2025
pandeyanshuman
pushed a commit
to pandeyanshuman/cadence-java-client
that referenced
this pull request
Oct 13, 2025
Signed-off-by: Shijie Sheng <[email protected]> What changed? Add new internal entities that will replace thrift ones. These entities will be used in the next few diffs that removed thrift support. To generate entities, ./scripts/v4_entity_generator/run.sh Why? Thrift entities are not easily replaceable by GRPC ones. One quick approach for deprecation is to generate similar interface internal entities to replace thrift ones. How did you test it? These are generated by script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add new internal entities that will replace thrift ones.
These entities will be used in the next few diffs that removed thrift support.
To generate entities,
./scripts/v4_entity_generator/run.shWhy?
Thrift entities are not easily replaceable by GRPC ones. One quick approach for deprecation is to generate similar interface internal entities to replace thrift ones.
How did you test it?
These are generated by script
Potential risks
Release notes
Documentation Changes