Support gRPC Headers from ClientOptions and correct Scope Handling#1039
Merged
natemort merged 1 commit intocadence-workflow:v3.13.xfrom Nov 18, 2025
Merged
Support gRPC Headers from ClientOptions and correct Scope Handling#1039natemort merged 1 commit intocadence-workflow:v3.13.xfrom
natemort merged 1 commit intocadence-workflow:v3.13.xfrom
Conversation
Allow additional headers to be added via ClientOptions, similar to TChannel. Additionally support removing headers by setting built-in headers values to null or an empty string. Refactor OpenTracingInterceptor to a separate file and correct Scope handling to resolve Context mismatches. Leaving the Scope open during initialization and then closing it during onClose is incorrect and can cause issues with other interceptors. It's difficult to test this change in isolation.
shijiesheng
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow additional headers to be added via ClientOptions, similar to TChannel. Additionally support removing headers by setting built-in headers values to null or an empty string.
Refactor OpenTracingInterceptor to a separate file and correct Scope handling to resolve Context mismatches. Leaving the Scope open during initialization and then closing it during onClose is incorrect and can cause issues with other interceptors. It's difficult to test this change in isolation.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes