feat: Dual emitting timer and histogram metrics#1048
Open
neil-xie wants to merge 2 commits intocadence-workflow:masterfrom
Open
feat: Dual emitting timer and histogram metrics#1048neil-xie wants to merge 2 commits intocadence-workflow:masterfrom
neil-xie wants to merge 2 commits intocadence-workflow:masterfrom
Conversation
neil-xie
requested review from
abhishekj720,
demirkayaender,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Neil Xie <neil.xie@uber.com>
neil-xie
force-pushed
the
timer_metrics_migration
branch
from
ed92900 to
992260c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Start dual emitting histogram metrics as part of timer -> histogram metrics migration
Added migration doc to example the changes
Why?
Time -> histogram migration
cadence-workflow/cadence#7741
How did you test it?
Unit test
Potential risks
Backward compatibility, only risk is the metrics storage usage increase
Release notes
Documentation Changes