thrift install script #939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
|
Can you update CONTRIBUTING.md with a reference to this script? |
natemort
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Maybe include macos in the file name like install-thrift-macos?
There was a problem hiding this comment.
good call, I was thinking of making it agnostic, but didn't, let me do that
natemort
approved these changes
Nov 4, 2024
taylanisikdemir
approved these changes
Nov 4, 2024
abhishekj720
approved these changes
Nov 4, 2024
davidporter-id-au
merged commit 26d90e1
into
cadence-workflow:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds a small script for installing thrift locally
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes