adds coverage to SignalExternalWorkflowParameters struct file's methods #944
Conversation
davidporter-id-au
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
|
|
||
| @Override | ||
| public String toString() { | ||
|
|
There was a problem hiding this comment.
this whole thing seems utterly pointless and not good personally I'd rather see JSON representation, but fixing it up since god forbid, someone mgiht actually be caring about it's current not good structure.
the main issue is that before, it broke for short strings, which is probably not what you want for a tostring
| SignalExternalWorkflowParameters result = new SignalExternalWorkflowParameters(); | ||
| result.setInput(input); | ||
| result.setRunId(runId); | ||
| result.setDomain(domain); |
There was a problem hiding this comment.
I guess this was missing also?
davidporter-id-au
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2 participants
What changed?
Adds a small amount of coverage to some internal data object. Fixes up the toString since it seemed to be broken.
Why?
We're trying to lift the coverage and quality of these repos. Incidentally I'm trying to remember how to write Java.
How did you test it?
Potential risks
Release notes
Documentation Changes