Increase test coverage for proto/TypeMapper.java #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
shijiesheng and
taylanisikdemir
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3vilhamster
approved these changes
Nov 25, 2024
Contributor
3vilhamster
left a comment
3vilhamster
left a comment
There was a problem hiding this comment.
Looks neat :)
I wonder if we can have more of Parameterized in the tests to eliminate boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes