Added tests for LocalActivityOptions #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobht
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort,
shijiesheng and
taylanisikdemir
as code owners
jakobht
force-pushed
the
TestLocalActivityOptions
branch
from
7945c68 to
4e75b0f
Compare
jakobht
force-pushed
the
TestLocalActivityOptions
branch
from
4e75b0f to
0945169
Compare
dkrotx
approved these changes
Nov 28, 2024
|
|
||
| final String expected = | ||
| "LocalActivityOptions{" | ||
| + "scheduleToCloseTimeout=PT2M3S, " |
There was a problem hiding this comment.
I would expect it to be more human-readable, but that's OK as well :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added tests for LocalActivityOptions so we are now at 89% coverage for this file
Why?
Increase coverage
How did you test it?
Potential risks
Release notes
Documentation Changes