added WorkflowServiceGrpc and IWorkflowServiceV4 #999
Conversation
shijiesheng
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort and
taylanisikdemir
as code owners
|
Is this a complete switch to GRPC, so we're throwing away thrift? |
I finally get the chance to add the unit test for mappers. To answer your question, I mainly need reviews on 1:1 comparison of thrift vs newly added entities. Others are captured by mappers tests. |
build.gradle
Outdated
| compile group: 'com.google.api.grpc', name: 'proto-google-common-protos', version: '2.10.0' | ||
| compile group: 'com.google.protobuf', name: 'protobuf-java-util', version: '3.21.9' | ||
| compile group: 'com.google.oauth-client', name: 'google-oauth-client', version: '1.35.0' | ||
| compile group: 'org.projectlombok', name: 'lombok', version: '1.18.30' |
There was a problem hiding this comment.
We should only need the compileOnly dependency. We don't want to include this at runtime.
| class DecisionMapper { | ||
| static List<Decision> decisionArray(List<com.uber.cadence.entities.Decision> t) { | ||
| if (t == null) { | ||
| return null; |
shijiesheng
force-pushed
the
grpc-service
branch
from
5c87773 to
3c1e906
Compare
build.gradle
Outdated
| } | ||
| java { | ||
| srcDir 'src/main' | ||
| srcDir '.gen' |
There was a problem hiding this comment.
With idiomatic Java you pretty much never check in generated sources (unlike Go).
But we don't want to run the generator as part of the build step and want to eventually delete the generator entirely. At which point we'd want to put it in src/main/java with all the other sources.
I think it makes the most sense to put it in like src/gen/java/ and then we merge it into src/main/java later.
The .gen directory pattern just seems really strange from a Java perspective.
What changed? added client entities that maps 1:1 with thrift (generated from a generator) added BaseError, which is a catchall similar to TException. added mappers to transform Proto to client entities. (mostly copied from thrift mappers) added IWorkflowServiceV4 which is exactly same as IWorkflowService except for it's using the client entities. added WorkflowServiceGrpc that implements the V4 interface Plan new V4 interface with new entities < This PR replace all pointers to V4 in one go (Should be import change only) Why? Thrift deprecation work How did you test it? Unit Test on mappers from ClientObjects to ProtoObjects
What changed? added client entities that maps 1:1 with thrift (generated from a generator) added BaseError, which is a catchall similar to TException. added mappers to transform Proto to client entities. (mostly copied from thrift mappers) added IWorkflowServiceV4 which is exactly same as IWorkflowService except for it's using the client entities. added WorkflowServiceGrpc that implements the V4 interface Plan new V4 interface with new entities < This PR replace all pointers to V4 in one go (Should be import change only) Why? Thrift deprecation work How did you test it? Unit Test on mappers from ClientObjects to ProtoObjects
4 participants
What changed?
BaseError, which is a catchall similar toTException.Plan
Why?
Thrift deprecation work
How did you test it?
Unit Test on mappers from ClientObjects to ProtoObjects
Potential risks
Release notes
Documentation Changes