remove duplicate logic

Signed-off-by: Tim Li <[email protected]>

Author: timl3136

cadence/client.py

@@ -218,28 +218,6 @@ async def start_workflow(
         except Exception as e:
             raise Exception(f"Failed to start workflow: {e}") from e
 
-    async def execute_workflow(
-        self,
-        workflow: Union[str, Callable],
-        *args,
-        **options_kwargs
-    ) -> WorkflowExecution:
-        """
-        Start a workflow execution and return the execution handle.
-
-        Args:
-            workflow: Workflow function or workflow type name string
-            *args: Arguments to pass to the workflow
-            **options_kwargs: StartWorkflowOptions as keyword arguments
-
-        Returns:
-            WorkflowExecution that contains workflow_id and run_id
-
-        Raises:
-            ValueError: If required parameters are missing or invalid
-            Exception: If the gRPC call fails
-        """
-        return await self.start_workflow(workflow, *args, **options_kwargs)
 
 
 

tests/cadence/test_client_workflow.py

@@ -276,48 +276,49 @@ async def mock_build_request(workflow, args, options):
         assert captured_options.execution_start_to_close_timeout == timedelta(minutes=30)
 
 
-class TestClientExecuteWorkflow:
-    """Test Client.execute_workflow method."""
+class TestClientStartWorkflow:
+    """Test Client.start_workflow method."""
 
     @pytest.mark.asyncio
-    async def test_execute_workflow_success(self, mock_client):
-        """Test successful workflow execution."""
-        # Mock start_workflow to return execution
+    async def test_start_workflow_success(self, mock_client):
+        """Test successful workflow start."""
+        # Mock the gRPC stub
         execution = WorkflowExecution()
         execution.workflow_id = "test-workflow-id"
         execution.run_id = "test-run-id"
 
+        response = StartWorkflowExecutionResponse()
+        response.run_id = "test-run-id"
+
         client = Client(domain="test-domain", target="localhost:7933")
-        client.start_workflow = AsyncMock(return_value=execution)
+        client._workflow_stub = Mock()
+        client._workflow_stub.StartWorkflowExecution = AsyncMock(return_value=response)
 
-        result_execution = await client.execute_workflow(
+        result_execution = await client.start_workflow(
             "TestWorkflow",
             "arg1", "arg2",
-            task_list="test-task-list"
+            task_list="test-task-list",
+            workflow_id="test-workflow-id"
         )
 
         assert isinstance(result_execution, WorkflowExecution)
-        assert result_execution is execution
         assert result_execution.workflow_id == "test-workflow-id"
         assert result_execution.run_id == "test-run-id"
 
-        # Verify start_workflow was called with correct arguments
-        client.start_workflow.assert_called_once_with(
-            "TestWorkflow",
-            "arg1", "arg2",
-            task_list="test-task-list"
-        )
+        # Verify gRPC call was made
+        client._workflow_stub.StartWorkflowExecution.assert_called_once()
 
     @pytest.mark.asyncio
-    async def test_execute_workflow_propagates_error(self, mock_client):
-        """Test that execute_workflow propagates errors from start_workflow."""
+    async def test_start_workflow_propagates_error(self, mock_client):
+        """Test that start_workflow propagates gRPC errors."""
         client = Client(domain="test-domain", target="localhost:7933")
-        client.start_workflow = AsyncMock(side_effect=ValueError("Invalid task_list"))
+        client._workflow_stub = Mock()
+        client._workflow_stub.StartWorkflowExecution = AsyncMock(side_effect=ValueError("gRPC error"))
 
-        with pytest.raises(ValueError, match="Invalid task_list"):
-            await client.execute_workflow(
+        with pytest.raises(Exception, match="Failed to start workflow"):
+            await client.start_workflow(
                 "TestWorkflow",
-                task_list=""
+                task_list="valid-task-list"
             )
 
 
@@ -334,7 +335,7 @@ async def test_integration_workflow_invocation():
     client._workflow_stub.StartWorkflowExecution = AsyncMock(return_value=response)
 
     # Test the complete flow
-    execution = await client.execute_workflow(
+    execution = await client.start_workflow(
         "IntegrationTestWorkflow",
         "test-arg",
         42,