Skip to content

Conversation

shijiesheng
Copy link
Member

What changed?

  • use grpc_tools to generate proto files

Why?

avoid local compiling protoc

How did you test it?

Unit Test

Manual Test with client_example.py

Potential risks

Release notes

Documentation Changes

@timl3136
Copy link
Member

timl3136 commented Aug 28, 2025

we might need to add a line in readme that in order to generate the files, it requires using dev dependency via uv sync --extra dev since uv sync will not install all the necessary modules for generate proto.
Otherwise LGTM, thanks for doing this.

@shijiesheng shijiesheng merged commit 0039ea2 into cadence-workflow:main Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants