Skip to content

Conversation

natemort
Copy link
Member

What changed?

  • Make DataConverter match Go rather than Java.

Why?

  • The Go DataConverter's approach is unique and potentially difficult to parse. But it's unambiguous. The Java client either wraps the input into a json array, or encodes it as-is if there's a single value. This ends up being ambiguous as to how it should be decoded any time a List is one of the arguments.
  • We could alternatively always wrap the arguments into a list, but introducing a third standard seems worse.

How did you test it?

  • Unit tests

Potential risks

  • None

Release notes

Documentation Changes

@natemort natemort force-pushed the activity_definition branch 2 times, most recently from 6c5c5fd to 97fb071 Compare September 29, 2025 21:53
Copy link
Member

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nathanael Mortensen <[email protected]>
@natemort natemort force-pushed the activity_definition branch from 97fb071 to 7fb8741 Compare October 1, 2025 16:22
@natemort natemort merged commit fb3e42d into cadence-workflow:main Oct 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants