chore: add a makefile to run linter/testing/type safety check #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Li <[email protected]>
Signed-off-by: Tim Li <[email protected]>
timl3136
force-pushed
the
simple_makefile
branch
from
d86545b to
1b879cf
Compare
shijiesheng
reviewed
Oct 28, 2025
| @echo "All PR checks passed!" | ||
|
|
||
| # Install dependencies | ||
| install: |
Member
Author
There was a problem hiding this comment.
Thanks, I have added the generate rule which is consistent with go-client's makefile rule
Signed-off-by: Tim Li <[email protected]>
shijiesheng
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
add a makefile to run linter/testing/type safety check, now we can run
make prto check all the linter etc. in one go.Why?
it's sometimes confusion for all the different
uv runcommands to either run test, linter.How did you test it?
only makefile
Potential risks
Release notes
Documentation Changes