-
Notifications
You must be signed in to change notification settings - Fork 125
feat: Show summarized history event details in event group row #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Show summarized history event details in event group row #1106
Conversation
88b5e7a to
f3d52a3
Compare
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
f3d52a3 to
ea0f3b7
Compare
Signed-off-by: Adhitya Mamallan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a single-line summary feature for workflow history event groups, replacing placeholder text with an interactive details row component that displays key event information in a compact, readable format.
Key Changes:
- Introduces a reusable
WorkflowHistoryDetailsRowcomponent with tooltip support and customizable rendering - Implements a parser configuration system to handle different detail types (JSON, timeouts, heartbeats, retries)
- Adds style adjustments to accommodate the new summary display with responsive margin handling
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-history-event-group.tsx | Integrates the new details row component with computed groupSummaryDetails, replacing placeholder text |
| workflow-history-event-group.styles.ts | Adds responsive margin styling for the summarized details container |
| workflow-history-details-row/* | Core component implementing the details row with tooltip support and configurable item rendering |
| workflow-history-details-row-json/* | JSON value renderer component with ellipsis overflow handling |
| workflow-history-details-row-tooltip-json/* | Tooltip component for displaying formatted JSON previews |
| get-parsed-details-row-items.ts | Helper function that transforms detail entries using parser configurations |
| workflow-history-details-row-parsers.config.ts | Parser configuration defining how different detail types are matched and rendered |
| Test files | Comprehensive unit tests for components and helper functions with good coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-details-row/workflow-history-details-row.tsx
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-details-row/workflow-history-details-row.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/config/workflow-history-details-row-parsers.config.ts
Show resolved
Hide resolved
...low-history-v2/workflow-history-details-row-json/workflow-history-details-row-json.styles.ts
Show resolved
Hide resolved
src/views/workflow-history-v2/config/workflow-history-details-row-parsers.config.ts
Outdated
Show resolved
Hide resolved
|
|
||
| export type DetailsRowValueComponentProps = { | ||
| label: string; | ||
| value: any; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value field is typed as any, which bypasses type safety. Consider using unknown instead to force type checking at usage sites, or define a more specific union type if the possible value types are known:
value: unknown;This applies to both DetailsRowValueComponentProps and DetailsRowItem types.
| export type DetailsRowItem = { | ||
| path: string; | ||
| label: string; | ||
| value: any; |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value field is typed as any, which bypasses type safety. Consider using unknown instead:
value: unknown;| value: any; | |
| value: unknown; |
Signed-off-by: Adhitya Mamallan <[email protected]>
Summary
Test plan
Unit tests + ran locally.
JSON on hover
On narrow screens