Skip to content

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Dec 4, 2025

Summary

  • Add WorkflowHistoryRowDetails component that displays summarized details in the event group entry
  • Add components for the row JSON and the on-hover tooltip JSON

Test plan

Unit tests + ran locally.

Screenshot 2025-12-08 at 11 20 21 Screenshot 2025-12-08 at 11 20 39

JSON on hover

Screenshot 2025-12-08 at 11 23 01

On narrow screens

Screenshot 2025-12-08 at 11 20 48

@adhityamamallan adhityamamallan force-pushed the history-single-line-summary branch 2 times, most recently from 88b5e7a to f3d52a3 Compare December 5, 2025 13:15
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
@adhityamamallan adhityamamallan force-pushed the history-single-line-summary branch from f3d52a3 to ea0f3b7 Compare December 8, 2025 09:45
Signed-off-by: Adhitya Mamallan <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a single-line summary feature for workflow history event groups, replacing placeholder text with an interactive details row component that displays key event information in a compact, readable format.

Key Changes:

  • Introduces a reusable WorkflowHistoryDetailsRow component with tooltip support and customizable rendering
  • Implements a parser configuration system to handle different detail types (JSON, timeouts, heartbeats, retries)
  • Adds style adjustments to accommodate the new summary display with responsive margin handling

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
workflow-history-event-group.tsx Integrates the new details row component with computed groupSummaryDetails, replacing placeholder text
workflow-history-event-group.styles.ts Adds responsive margin styling for the summarized details container
workflow-history-details-row/* Core component implementing the details row with tooltip support and configurable item rendering
workflow-history-details-row-json/* JSON value renderer component with ellipsis overflow handling
workflow-history-details-row-tooltip-json/* Tooltip component for displaying formatted JSON previews
get-parsed-details-row-items.ts Helper function that transforms detail entries using parser configurations
workflow-history-details-row-parsers.config.ts Parser configuration defining how different detail types are matched and rendered
Test files Comprehensive unit tests for components and helper functions with good coverage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


export type DetailsRowValueComponentProps = {
label: string;
value: any;
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value field is typed as any, which bypasses type safety. Consider using unknown instead to force type checking at usage sites, or define a more specific union type if the possible value types are known:

value: unknown;

This applies to both DetailsRowValueComponentProps and DetailsRowItem types.

Copilot uses AI. Check for mistakes.
export type DetailsRowItem = {
path: string;
label: string;
value: any;
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value field is typed as any, which bypasses type safety. Consider using unknown instead:

value: unknown;
Suggested change
value: any;
value: unknown;

Copilot uses AI. Check for mistakes.
@adhityamamallan adhityamamallan changed the title feat: History single line summary feat: Show summarized history event details in event group row Dec 8, 2025
Signed-off-by: Adhitya Mamallan <[email protected]>
@adhityamamallan adhityamamallan marked this pull request as ready for review December 8, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant