Skip to content

fix: Do not toggle "Show all" when all tags are manually selected #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhityamamallan merged 1 commit into from
Dec 9, 2025
+7 −23
Merged

fix: Do not toggle "Show all" when all tags are manually selected #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/components/tag-filter/__tests__/tag-filter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,6 @@ describe(TagFilter.name, () => {
expect(mockOnChangeValues).toHaveBeenCalledWith([]);
});

it('automatically toggles to "show all" (empty array) when the last tag is clicked and all tags become selected', async () => {
const { user, mockOnChangeValues } = setup({
values: ['opt1', 'opt2'],
});

// Click the last tag to select all tags - should auto-toggle to empty array
await user.click(screen.getByText('Option 3'));

expect(mockOnChangeValues).toHaveBeenCalledWith([]);
});

it('does not render "Show all" tag when hideShowAll is true', () => {
setup({
hideShowAll: true,
Expand Down
19 changes: 7 additions & 12 deletions src/components/tag-filter/tag-filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,13 @@ export default function TagFilter<T extends string>({
const isShowAll = useMemo(() => values.length === 0, [values]);

const onChangeSingleValue = useCallback(
(value: T) => {
const newValues = values.includes(value)
? values.filter((v) => v !== value)
: [...values, value];

// If all tags are selected, automatically toggle to "show all" (empty array)
const areAllTagsSelected = tagKeys.every((key) =>
newValues.includes(key)
);
onChangeValues(areAllTagsSelected ? [] : newValues);
},
[values, onChangeValues, tagKeys]
(value: T) =>
onChangeValues(
values.includes(value)
? values.filter((v) => v !== value)
: [...values, value]
),
[values, onChangeValues]
);

return (
Expand Down