Skip to content

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Dec 10, 2025

Summary

Implement WorkflowHistoryUngroupedEvent component

Test plan

Unit tests + ran locally.

Screenshot 2025-12-10 at 15 25 59 Screenshot 2025-12-10 at 15 26 13

Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
Signed-off-by: Adhitya Mamallan <[email protected]>
@adhityamamallan adhityamamallan changed the title History ungrouped event feat: Workflow History V2 - ungrouped event row Dec 10, 2025
Signed-off-by: Adhitya Mamallan <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a new ungrouped event row component for Workflow History V2, transitioning from a temporary placeholder to a fully functional UI component with collapsible event details, status badges, and reset functionality.

Key Changes

  • Replaced placeholder implementation with a complete accordion-based event row using BaseUI Panel component
  • Added comprehensive styling with responsive grid layouts and animation support for event highlighting
  • Implemented thorough test coverage with 15+ test cases covering expansion states, reset functionality, and detail rendering

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
workflow-history-ungrouped-event.tsx Implements the main component with event display, status badges, duration calculations, and expandable group details
workflow-history-ungrouped-event.styles.ts Defines styled components and overrides for the Panel component with responsive grid layouts and hover animations
workflow-history-ungrouped-event.test.tsx Adds comprehensive test suite covering event rendering, expansion behavior, reset functionality, and edge cases
Comments suppressed due to low confidence (1)

src/views/workflow-history-v2/workflow-history-ungrouped-event/workflow-history-ungrouped-event.styles.ts:165

  • The badge property in the overrides object is never used in the component. Only overrides.panel is referenced in workflow-history-ungrouped-event.tsx (line 116). Consider removing this unused code to reduce maintenance burden, or if it's intended for future use, add a comment explaining its purpose.
        whiteSpace: 'nowrap',
        marginLeft: $theme.sizing.scale100,
      }),
    },
  } satisfies BadgeOverrides,
});


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adhityamamallan adhityamamallan marked this pull request as ready for review December 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants