fix: Show duration badges immediately for running workflows without breaking event polling

[pandeyanshuman]

Problem

When viewing an in-progress workflow's history, the Duration badge (blue pill showing "Duration: Xm Xs") stays hidden for ~50 seconds. This happens because waitForNewEvent: true causes the server to long-poll on the first empty page, and the badge waits for that response before showing.

A previous attempt to fix this (suppressing waitForNewEvent until the first empty page) broke event polling entirely: the Cadence server does not return nextPageToken when waitForNewEvent is false and there are no more events, so the fetcher's infinite query stops with hasNextPage: false and never polls for new events on running workflows.

Solution

Instead of modifying the fetcher's waitForNewEvent behavior (which breaks server-side long polling), fix the problem at the badge level: duration badges for running workflows now display immediately as "ongoing" (ticking) while events are still loading, rather than hiding until all history pages are fetched.

For completed workflows, badges still hide during loading since the final duration isn't known until the closing event is fetched.

Changes

• workflow-history-fetcher.ts: Reverted hasReceivedEmptyPage flag and response interception. waitForNewEvent is now passed through directly from params, restoring correct long-polling behavior.
• workflow-history-events-duration-badge.tsx: Changed noDuration condition from loadingMoreEvents || ... to (loadingMoreEvents && workflowEnded) || ... so running workflows show an ongoing duration badge during loading.
• workflow-history-remaining-duration-badge.tsx: Changed shouldHide from loadingMoreEvents || workflowEnded to workflowEnded since this badge is only for running workflows and doesn't need to wait for loading.
• Tests updated to reflect the new behavior across all three components.

Test plan

• Unit tests pass for workflow-history-fetcher (npx jest --testPathPattern="workflow-history-fetcher" --no-coverage)
• Unit tests pass for events-duration-badge (npx jest --testPathPattern="workflow-history-events-duration-badge" --no-coverage)
• Unit tests pass for remaining-duration-badge (npx jest --testPathPattern="workflow-history-remaining-duration-badge" --no-coverage)
• Manual test: Open a running workflow with many events, verify the Duration badge appears immediately (no 50s delay)
• Manual test: Verify the UI continues polling for new events on a running workflow (new events appear in real-time)
• Manual test: Open a completed workflow, verify duration badges show correct final values after loading

[Assem-Uber]

Fetcher seems to stop with the new changes:
Before:

After:

I expect this happens as the server doesn't return nextPageToken when waitForEvents is false and there are no more events

[pandeyanshuman]

Thanks @Assem-Uber - I have updated the logic to fix the original issue and the issue you identified with my previous implementation.

[Assem-Uber]

Unfortunately this approach would show false timers for incomplete groups (In an in-progress workflow). A timer between the event and now would show by default until the complete event is loaded.
Attaching screen recording in next comment

[Assem-Uber]

This is a good catch

[Assem-Uber]

Attaching screen recording in next comment

Screen.Recording.2026-03-24.at.12.52.13.mov

[gitar-bot]

💡 Quality: Unused loadingMoreEvents prop in remaining-duration-badge

After the change on line 21 of workflow-history-remaining-duration-badge.tsx, shouldHide no longer references loadingMoreEvents. The prop is still declared in the Props type (line 9 of the types file) and destructured (line 15 of the component) but never used. This is dead code that will confuse future readers into thinking loading state still affects this badge.

Suggested fix:

Remove `loadingMoreEvents` from the `Props` type in the `.types.ts` file, remove it from the destructured props in the component, and remove it from all call sites passing it to this component.

_{Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Fixes duration badge display for running workflows by enabling event polling after the first empty page instead of suppressing it entirely. Consider removing the unused loadingMoreEvents prop from remaining-duration-badge.

💡 Quality: Unused loadingMoreEvents prop in remaining-duration-badge

📄 src/views/workflow-history/workflow-history-remaining-duration-badge/workflow-history-remaining-duration-badge.tsx:15 📄 src/views/workflow-history/workflow-history-remaining-duration-badge/workflow-history-remaining-duration-badge.tsx:21

After the change on line 21 of workflow-history-remaining-duration-badge.tsx, shouldHide no longer references loadingMoreEvents. The prop is still declared in the Props type (line 9 of the types file) and destructured (line 15 of the component) but never used. This is dead code that will confuse future readers into thinking loading state still affects this badge.

Suggested fix

Remove `loadingMoreEvents` from the `Props` type in the `.types.ts` file, remove it from the destructured props in the component, and remove it from all call sites passing it to this component.

🤖 Prompt for agents

Code Review: Fixes duration badge display for running workflows by enabling event polling after the first empty page instead of suppressing it entirely. Consider removing the unused `loadingMoreEvents` prop from remaining-duration-badge.

1. 💡 Quality: Unused `loadingMoreEvents` prop in remaining-duration-badge
   Files: src/views/workflow-history/workflow-history-remaining-duration-badge/workflow-history-remaining-duration-badge.tsx:15, src/views/workflow-history/workflow-history-remaining-duration-badge/workflow-history-remaining-duration-badge.tsx:21

   After the change on line 21 of `workflow-history-remaining-duration-badge.tsx`, `shouldHide` no longer references `loadingMoreEvents`. The prop is still declared in the `Props` type (line 9 of the types file) and destructured (line 15 of the component) but never used. This is dead code that will confuse future readers into thinking loading state still affects this badge.

   Suggested fix:
   Remove `loadingMoreEvents` from the `Props` type in the `.types.ts` file, remove it from the destructured props in the component, and remove it from all call sites passing it to this component.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}