Skip to content

feat: Update docker file #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Assem-Uber merged 5 commits into from
Apr 1, 2026
+18 −30
Merged

feat: Update docker file #1225

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff506af
update docker image
Assem-Uber Mar 27, 2026
e8b06b9
update env variables
Assem-Uber Mar 27, 2026
97139fd
remove apt-get cache
Assem-Uber Mar 27, 2026
0797ff2
Merge branch 'master' into feature/update-docker-image
Assem-Uber Apr 1, 2026
288b8b1
push docker
Assem-Uber Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 15 additions & 27 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,53 +1,41 @@
FROM node:18-alpine AS base

RUN apk update
RUN apk --no-cache add git
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
RUN apk add --no-cache libc6-compat

# Install dependencies only when needed
FROM base AS deps
WORKDIR /app

# Install dependencies based on the preferred package manager
COPY package.json package-lock.json ./
RUN npm ci
RUN npm run install-idl


FROM node:18-bookworm-slim AS base

FROM base AS dev

# Install git + CA bundle so git https can verify TLS
RUN apt-get update \
&& apt-get install -y --no-install-recommends git ca-certificates
WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
COPY . .



# Rebuild the source code only when needed
FROM base AS builder
WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
RUN apt-get update \
&& apt-get install -y --no-install-recommends git ca-certificates
COPY package.json package-lock.json ./
RUN npm ci
RUN npm run install-idl
COPY . .

# Next.js collects completely anonymous telemetry data about general usage.
# Learn more here: https://nextjs.org/telemetry
# Uncomment the following line in case you want to disable telemetry during the build.
ENV NEXT_TELEMETRY_DISABLED 1
ENV NEXT_TELEMETRY_DISABLED=1
Copy link
Copy Markdown
Contributor

@YoavLev YoavLev Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is already uncommented, is this on purpose? Why do we need next telemetry anyways?

Copy link
Copy Markdown
Contributor Author

@Assem-Uber Assem-Uber Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we don't need to enable the opentelemetry. We just need to remove the comment above

# optimize Build size by including only required resources


RUN npm run generate:idl
RUN npm run build
RUN npm run build-standalone
RUN npm run post-build-standalone

# Production image, copy all the files and run next
# Production image, copy necessary files and run next
FROM base AS runner
WORKDIR /app

ENV NODE_ENV production
ENV NODE_ENV=production
# Uncomment the following line in case you want to disable telemetry during runtime.
ENV NEXT_TELEMETRY_DISABLED 1
ENV NEXT_TELEMETRY_DISABLED=1

RUN addgroup --system --gid 1001 nodejs
RUN adduser --system --uid 1001 nextjs
Expand All @@ -61,7 +49,7 @@ RUN chown nextjs:nodejs .next

# Automatically leverage output traces to reduce image size
# https://nextjs.org/docs/advanced-features/output-file-tracing
COPY --from=builder --chown=nextjs:nodejs /app/src/__generated__/ ./src/__generated__/
COPY --from=builder --chown=nextjs:nodejs /app/src/__generated__/ ./src/__generated__/
COPY --from=builder --chown=nextjs:nodejs /app/.next/standalone ./
COPY --from=builder --chown=nextjs:nodejs /app/.next/static ./.next/static

Expand Down
Loading
Loading