feat: [1/n] Add hook, helper & static config for new Workflows List rendering#1228
feat: [1/n] Add hook, helper & static config for new Workflows List rendering#1228adhityamamallan wants to merge 5 commits intocadence-workflow:masterfrom
Conversation
src/views/shared/workflows-list/hooks/use-workflows-list-columns.ts
Outdated
Show resolved
Hide resolved
src/views/shared/workflows-list/config/workflows-list-columns.config.ts
Outdated
Show resolved
Hide resolved
68fba7f to
5c3978f
Compare
Add types, constants, column matchers config, search attribute resolver, and useWorkflowsListColumns hook that will power the new workflows list. Made-with: Cursor Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
5c3978f to
a7db81c
Compare
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Code Review ✅ Approved 2 resolved / 2 findingsAdds hook, helper, and static config infrastructure for the new Workflows List rendering, addressing useState initialization with readonly tuples and invalid date handling in DATETIME renderCell. No remaining issues found. ✅ 2 resolved✅ Bug: useState initialized with readonly tuple, resetColumns creates new array
✅ Edge Case: DATETIME renderCell returns NaN FormattedDate for invalid dates
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Summary
Add hook, helper and static config for new Workflows List. This is 1/n in a stack of PRs.
useWorkflowsListColumnshook to fetch search attributes and manage column visibility/selection stateworkflows-list-columns.config.tswith matcher rules for system attributes (WorkflowID, CloseStatus, RunID, WorkflowType, StartTime, CloseTime) and datetime typesgetWorkflowsListColumnFromSearchAttributehelper to convert search attributes into renderable columns with type-aware formattingWorkflowsListColumnandWorkflowsListColumnMatchertypes, plusPropstype for the list componentDEFAULT_WORKFLOWS_LIST_COLUMNSconstant andDEFAULT_WORKFLOWS_LIST_COLUMN_WIDTHfor layoutTest plan
Unit tests + tested in follow-up PRs.