chore: update dependencies and fix type issue in useConfigValue hook#920
Open
drjoeycadieux wants to merge 1 commit intocadence-workflow:masterfrom
Open
chore: update dependencies and fix type issue in useConfigValue hook#920drjoeycadieux wants to merge 1 commit intocadence-workflow:masterfrom
drjoeycadieux wants to merge 1 commit intocadence-workflow:masterfrom
Conversation
- Updated various dependencies to their latest versions for improved performance and security, including: - @grpc/grpc-js, @grpc/proto-loader, @hookform/resolvers, @opentelemetry packages, @tanstack/react-query, and others. - Updated React and React DOM to version 18.3.1. - Fixed a type issue in the useConfigValue hook by adding a TypeScript ignore comment for compatibility with newer versions of react-query.
Contributor
|
This is touching many places at the same time. It is better to break it into different PRs. |
Assem-Uber
reviewed
Jun 2, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM node:18-alpine AS base | |||
| FROM node:18.20-alpine AS base | |||
Contributor
There was a problem hiding this comment.
Doesn't node:18-alpine use the latest by default?
| key: K, | ||
| args?: GetConfigArgs<K> | ||
| ): UseConfigValueResult<K> { | ||
| // @ts-expect-error Type issue with newer versions of react-query |
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Why do we need to update this file ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates dependencies and GitHub Actions workflows to enhance security, performance, and maintainability.
Changes
Package Updates
GitHub Actions Updates
Docker Configuration
Code Fixes
Security Improvements
Testing
Future Work
defaultPropsto use JavaScript default parameters