Skip to content

Rename workflow-summary-tab to workflow-summary #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Assem-Uber
Copy link
Contributor

Summary
Workflow summary page was not named in a similar convention for other tabs which ignored -tab postfix. To keep consistent workflow-summary-tab is renamed to workflow-summary

Testing
Checked if summary page loads correctly in dev environment.

@@ -4,7 +4,7 @@ import { render } from '@/test-utils/rtl';

import losslessJsonStringify from '@/utils/lossless-json-stringify';

import WorkflowSummaryTabJsonView from '../workflow-history-event-details-json';
import WorkflowHistoryEventDetailsJson from '../workflow-history-event-details-json';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants