Convert some pre-generics map.Keys/.Values to their generic version#6575
Merged
Groxx merged 12 commits intocadence-workflow:masterfrom Dec 23, 2024
Merged
Convert some pre-generics map.Keys/.Values to their generic version#6575Groxx merged 12 commits intocadence-workflow:masterfrom
Groxx merged 12 commits intocadence-workflow:masterfrom
Conversation
Groxx
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
taylanisikdemir
approved these changes
Dec 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very straightforward "replace custom code with stdlib".
Generics are great. I'm so glad we have them.
For reviewers: I would highly recommend reading each commit if you feel like being extra careful - each one is changing a single function, and is pretty trivial.