Consolidate docker image publishing in a single github workflow#6604
Merged
taylanisikdemir merged 8 commits intocadence-workflow:masterfrom Jan 9, 2025
Merged
Conversation
taylanisikdemir
commented
Jan 9, 2025
Comment on lines
+86
to
+88
| # TODO: Uncomment below once image tags are validated after merging | ||
| # push: ${{ needs.meta.outputs.push_enabled == 'true' }} | ||
| push: false |
Member
Author
There was a problem hiding this comment.
After merging this PR I will double check the image tags and then enable pushes in a follow up PR
taylanisikdemir
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165 and
shijiesheng
as code owners
Shaddoll
approved these changes
Jan 9, 2025
neil-xie
reviewed
Jan 9, 2025
| password: ${{ secrets.CADENCE_SERVER_DOCKERHUB_TOKEN }} | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| - name: Set up Docker Buildx |
Member
There was a problem hiding this comment.
Nice, I must have missed this step when I tried to publish multi-plat images, I was getting buildx not supported errors
neil-xie
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current State
Currently we have multiple CI jobs doing docker pushes.
Buildkite job pushes following images on each master push:
Github workflow is pushing following images on each release:
Problems:
Changes:
Testing
By triggering new workflow as part of this PR. Added a
check-metajob to double check conditional expressions. I will delete it later.After this PR merges, I will validate the master image pushes are working as expected.
After next release, I will also validate the same for release tagged images.