Add debug logs to task completer for task not started#6609
Merged
fimanishi merged 3 commits intocadence-workflow:masterfrom Jan 10, 2025
Merged
Add debug logs to task completer for task not started#6609fimanishi merged 3 commits intocadence-workflow:masterfrom
fimanishi merged 3 commits intocadence-workflow:masterfrom
Conversation
fimanishi
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
| } | ||
|
|
||
| func isActivityTaskStarted(task *InternalTask, workflowExecutionResponse *types.DescribeWorkflowExecutionResponse) bool { | ||
| func isActivityTaskStarted(task *InternalTask, workflowExecutionResponse *types.DescribeWorkflowExecutionResponse, logger log.Logger) bool { |
Member
There was a problem hiding this comment.
I would consider swapping this to be a method rather than passing the log along if you need to do metrics/logging, ie making this func (tc *taskCompleterImpl) isActivityTaskStarted so that you can do things like dc.logger.debug(... and metrics
| return true | ||
| } | ||
|
|
||
| logger.Debug(fmt.Sprintf("Activity task not started. TaskID: %v, ScheduleID: %v, PendingActivityState: %v", |
Member
There was a problem hiding this comment.
prefer to not interpolate logs since they're hard to group. If you can add those values as tags?
fimanishi
force-pushed
the
add-debug-logs-to-task-completer
branch
from
f3ba36f to
d7543cb
Compare
davidporter-id-au
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add debug logs for tasks that have not started in the task completer
Why?
Sanity check and debugging
How did you test it?
Will test in staging
Potential risks
Release notes
Documentation Changes