Skip to content

Modify ScheduleToStartTimeout error catching #7025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify ScheduleToStartTimeout error catching #7025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/history/task/timer_active_task_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ Loop:
// check if it's possible that the timeout is due to activity task lost
if timerSequenceID.TimerType == execution.TimerTypeScheduleToStart {
domainName, err := t.shard.GetDomainCache().GetDomainName(mutableState.GetExecutionInfo().DomainID)
if err == nil && activityInfo.ScheduleToStartTimeout >= int32(t.config.ActivityMaxScheduleToStartTimeoutForRetry(domainName).Seconds()) {
if err == nil && activityInfo.ScheduleToStartTimeout > int32(t.config.ActivityMaxScheduleToStartTimeoutForRetry(domainName).Seconds()) {
// note that we ignore the race condition for the dynamic config value change here as it's only for metric and logging purpose.
// theoratically the check only applies to activities with retry policy
// however for activities without retry policy, we also want to check the potential task lost and emit the metric
Expand Down
Loading