Do not generate scheduled task with timestamp in the past #7070
+53
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
force-pushed
the
timer
branch
2 times, most recently
from
b4ed805 to
14a3fcd
Compare
davidporter-id-au
approved these changes
Jul 16, 2025
dkrotx
pushed a commit
to dkrotx/cadence
that referenced
this pull request
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR picks a commit from temporal temporalio/temporal#4367
Why?
To improve the task queue latency metric for timer tasks. Currently, we guarantee that the timestamp of timers are greater than scheduledTaskMaxReadLevel to make sure that timers will be read from the database. But if a timer is assigned with a timestamp that's before now, the task queue latency can be abnormally high.
How did you test it?
unit tests
Potential risks
task queue latency metric could be wrong
Release notes
Documentation Changes