Skip to content

Convert replicator panics into errors, rather than crashing the process #7097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Convert replicator panics into errors, rather than crashing the process #7097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bef0c6
Convert replicator panics into errors, rather than crashing the process
Groxx Jul 24, 2025
a236fa1
switch to 16kb, a sample crash is almost 8kb
Groxx Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion service/history/ndc/history_replicator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ package ndc

import (
ctx "context"
"fmt"
"runtime"
"time"

"github.com/pborman/uuid"
Expand Down Expand Up @@ -342,7 +344,14 @@ func (r *historyReplicatorImpl) applyEvents(
defer func() {
if rec := recover(); rec != nil {
releaseFn(errPanic)
panic(rec)
stack := make([]byte, 1<<14) // 16kb
n := runtime.Stack(stack, false)
stack = stack[:n]
if retError == nil {
retError = fmt.Errorf("panic: %v, stack: %s", rec, stack)
} else {
retError = fmt.Errorf("panic: %v, stack: %s, previous err: %w", rec, stack, retError)
}
} else {
releaseFn(retError)
}
Expand Down
Loading