WIP: Actually-minimal histogram chnages, just extend our existing scopes #7220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also customizes the linter to find duplicate metrics names via the indexes, and WOW. almost 1000 of them. most look reasonable / they are very likely on the same scope... but not all. nowhere near all. so I think this might be the best argument in favor of the struct approach, actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also customizes the linter to find duplicate metrics names via the indexes, and WOW.
almost 1000 of them.
most look reasonable / they are very likely on the same scope... but not all. nowhere near all.
so I think this might be the best argument in favor of the struct approach, actually.